Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infosync: fully integrated PD HTTP client into InfoSyncer #49006

Merged
merged 5 commits into from
Dec 1, 2023
Merged

infosync: fully integrated PD HTTP client into InfoSyncer #49006

merged 5 commits into from
Dec 1, 2023

Conversation

JmPotato
Copy link
Member

@JmPotato JmPotato commented Nov 29, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #35319, tikv/pd#7300. Should merge after tikv/pd#7462.

Problem Summary:

Fully integrated PD HTTP client into InfoSyncer.

What changed and how does it work?

  • Replace the raw PD HTTP requests in InfoSyncer with the PD HTTP client completely.
  • Reuse the type definitions within the PD SDK as much as possible.

Check List

Tests

  • Unit test
  • Integration test

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@JmPotato
Fully integrated PD HTTP client into InfoSyncer
72f3c32 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 29, 2023
@JmPotato JmPotato mentioned this pull request Nov 29, 2023
Open
7 tasks
@codecov Codecov
Copy link

codecov bot commented Nov 29, 2023 •
edited
Loading

Codecov Report

Merging #49006 (f8cf570) into master (129be4c) will increase coverage by 1.2581%.
Report is 41 commits behind head on master.
The diff coverage is 23.3333%.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #49006        +/-   ##
================================================
+ Coverage   70.9775%   72.2357%   +1.2581%     
================================================
  Files          1368       1398        +30     
  Lines        404391     416878     +12487     
================================================
+ Hits         287027     301135     +14108     
+ Misses        97368      96800       -568     
+ Partials      19996      18943      -1053
Flag Coverage Δ
integration 43.8801% <23.3333%> (?)
unit 71.0249% <ø> (+0.0473%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (ø)
parser ∅ <ø> (∅)
br 48.3081% <0.0000%> (-4.7177%) ⬇️

@JmPotato
Fix the InfoSyncer test
296a147 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
JmPotato
JmPotato commented Nov 29, 2023
View reviewed changes
pkg/domain/infosync/info_test.go
@@ -279,43 +279,3 @@ func TestTiFlashManager(t *testing.T) {

CloseTiFlashManager(ctx)
}

func TestRuleOp(t *testing.T) {
Copy link
Member Author

@JmPotato JmPotato Nov 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove due to https://github.com/tikv/pd/pull/7462/files#diff-55223b29b1e0d97b9824b2bdf24c6f4a1b2b54bf408bb02182c06ffca8b8d0c3R52 and https://github.com/tikv/pd/pull/7462/files#diff-55223b29b1e0d97b9824b2bdf24c6f4a1b2b54bf408bb02182c06ffca8b8d0c3R114.

@JmPotato
Reduce the code
326330c 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@CabinfeverB
Copy link
Contributor

Sry, I will update client.go right now.

@CabinfeverB
Copy link
Contributor

Maybe we should upgrade client go by tikv/client-go#1069, and try to pass all CI test. If pass, we can merge tikv/client-go#1069 by force

@JmPotato JmPotato force-pushed the adpot_client_to_info_syncer branch 3 times, most recently from 1a43944 to 2036b87 Compare November 30, 2023 10:26
@JmPotato
Update the PD HTTP client version
77e05cd 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato
Update the client-go version
f8cf570 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@CabinfeverB
Copy link
Contributor

/test build

@tiprow tiprow
Copy link

tiprow bot commented Dec 1, 2023

@CabinfeverB: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 1, 2023
@disksing
Copy link
Contributor

disksing commented Dec 1, 2023

/merge

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 1, 2023
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 1, 2023

@disksing: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 1, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-01 05:45:20.027697668 +0000 UTC m=+1160748.692923861: ☑️ agreed by hawkingrei.
  • 2023-12-01 06:35:56.824727196 +0000 UTC m=+1163785.489953390: ☑️ agreed by disksing.

GMHDBJD
GMHDBJD approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: disksing, GMHDBJD, hawkingrei, tangenta, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 1, 2023
@JmPotato
Copy link
Member Author

JmPotato commented Dec 1, 2023

/test unit-test

@tiprow tiprow
Copy link

tiprow bot commented Dec 1, 2023

@JmPotato: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit 7353fbe into pingcap:master Dec 1, 2023
28 checks passed
@JmPotato JmPotato deleted the adpot_client_to_info_syncer branch December 1, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuJuncen YuJuncen YuJuncen approved these changes

@GMHDBJD GMHDBJD GMHDBJD approved these changes

@tangenta tangenta tangenta approved these changes

@disksing disksing disksing approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@JmPotato @CabinfeverB @disksing @hawkingrei @tangenta @GMHDBJD @YuJuncen